Re: [PATCH] Revert "serial: 8250: Clear CON_PRINTBUFFER on port re-registration"

[John Ogness]

On 2026-07-24, Fushuai Wang <fushuai.wang@xxxxxxxxx> wrote:
> From: Fushuai Wang <wangfushuai@xxxxxxxxx>
>
> This reverts commit d338ab1d90603f875c4f7ed223406535378173a5.
>
> This may cause some boot logs to be lost on some platforms.
>
> Reported-by: Mark Brown <broonie@xxxxxxxxxx>
> Reported-by: Anirudh Srinivasan <asrinivasan@xxxxxxxxxxxxxxxxxxx>
> Link: https://lore.kernel.org/all/20260522101042.21976-1-fushuai.wang@xxxxxxxxx/
> Signed-off-by: Fushuai Wang <wangfushuai@xxxxxxxxx>

Reviewed-by: John Ogness <john.ogness@xxxxxxxxxxxxx>

I also recently stumbled on commmit d338ab1d9060 ("serial: 8250: Clear
CON_PRINTBUFFER on port re-registration") and was surprised to see it
was accepted.

If the double-printing is happening for certain cases with 8250_pnp, I
would expect 8250_pnp (not 8250_core) to detect and handle that
case. 8250_core is the base for a lot of 8250 variants.

John Ogness