Re: [PATCH 1/4] dt-bindings: edac: altera: agilex5: document new edac support

[Krzysztof Kozlowski]

On Mon, Jul 20, 2026 at 03:14:22PM -0500, Dinh Nguyen wrote:
> The Agilex5 EDAC module supports ECC on a few additional peripherals. Along
> with support for ocram, ethernet and USB, the Agilex5 EDAC adds support for
> SDM QSPI, CRAM SEU and IO96B.
> 
> The Agilex5 EDAC also exposes up to 7 named interrupts on the manager
> node. global_sbe and global_dbe are aggregate single/double-bit error
> interrupts that fan-out through the manager's IRQ domain to the child
> peripheral ECCs. The remaining named interrupts are routed directly from
> dedicated controllers (IO96B memory controllers and Secure Device Manager)
> to the GIC.
> 
> Signed-off-by: Dinh Nguyen <dinguyen@xxxxxxxxxx>
> ---
>  .../edac/altr,socfpga-ecc-manager.yaml        | 23 ++++++++++++++++++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/edac/altr,socfpga-ecc-manager.yaml b/Documentation/devicetree/bindings/edac/altr,socfpga-ecc-manager.yaml
> index 136e8fccd429a..2ccb0f2163185 100644
> --- a/Documentation/devicetree/bindings/edac/altr,socfpga-ecc-manager.yaml
> +++ b/Documentation/devicetree/bindings/edac/altr,socfpga-ecc-manager.yaml
> @@ -22,6 +22,9 @@ properties:
>        - items:
>            - const: altr,socfpga-s10-ecc-manager
>            - const: altr,socfpga-a10-ecc-manager
> +      - items:
> +          - const: altr,socfpga-agilex5-ecc-manager

Same fallback, so this should be part of previous entry with enum.



> +          - const: altr,socfpga-a10-ecc-manager
>        - const: altr,socfpga-a10-ecc-manager
>        - const: altr,socfpga-ecc-manager
>  
> @@ -33,7 +36,25 @@ properties:
>  
>    interrupts:
>      minItems: 1
> -    maxItems: 2
> +    items:
> +      - description: Global single-bit error
> +      - description: Global double-bit error
> +      - description: IO96B0 DRAM controller error
> +      - description: IO96B1 DRAM controller error
> +      - description: SDM QSPI single-bit error
> +      - description: SDM QSPI double-bit error
> +      - description: SDM single-event
> +
> +  interrupt-names:
> +    minItems: 1
> +    items:
> +      - const: global_sbe
> +      - const: global_dbe
> +      - const: io96b0
> +      - const: io96b1
> +      - const: sdm_qspi_sbe
> +      - const: sdm_qspi_dbe
> +      - const: sdm_seu

Why now all existing devices get these new interrupts? And why 3 and 4
interrupts are valid for Agilex7? This is just unconstrained. Please
follow writing bindings doc.

Best regards,
Krzysztof