Re: [PATCH net-next v2 7/7] selftests: net: getsockopt_iter: cover rawv6, ieee802154, phonet and tls

From: Breno Leitao

Date: Fri Jul 24 2026 - 05:54:31 EST


On Thu, Jul 23, 2026 at 12:29:19PM +0200, Sabrina Dubroca wrote:

> The TLS tests themselves look good.
> Reviewed-by: Sabrina Dubroca <sd@xxxxxxxxxxxxxxx>

Thanks for the review!

> I guess there's a question here (for components that already have
> their own tests, so I think just tls for this patch) about whether
> getsockopt tests belong with the other component tests (net/tls.c) or
> in this getsockopt_iter group.

That's a good point. I've kept them together in this group for two reasons:

1) It simplifies cleanup once the full conversion is complete—we can
remove the entire group in one go (if needed)

2) It avoids inflating the selftest count, which helps keep NIPA CI
runs lean.

That said, I am happy to separate them, in case you think they would fit
better somewhere else.

--breno