Re: [PATCH] s390/sclp: Allow SCLP Action Qualifiers for Spyre card status reporting

From: Benjamin Block

Date: Fri Jul 24 2026 - 08:50:58 EST


On Fri, Jul 24, 2026 at 02:23:01PM +0200, Niklas Schnelle wrote:
> Add SCLP Action Qualifiers used by the Spyre stack for reporting of the
> card's initialization status, recoverable errors, and telemetry data.
>
> Co-developed-by: Andreas Krebbel <krebbel@xxxxxxxxxxxxx>
> Signed-off-by: Andreas Krebbel <krebbel@xxxxxxxxxxxxx>
> Signed-off-by: Niklas Schnelle <schnelle@xxxxxxxxxxxxx>
> ---
> arch/s390/include/asm/sclp.h | 3 +++
> drivers/s390/char/sclp_pci.c | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/arch/s390/include/asm/sclp.h b/arch/s390/include/asm/sclp.h
> index f2d490558054..44066550b9b1 100644
> --- a/arch/s390/include/asm/sclp.h
> +++ b/arch/s390/include/asm/sclp.h
> @@ -21,6 +21,9 @@
> #define SCLP_ERRNOTIFY_AQ_INFO_LOG 2
> #define SCLP_ERRNOTIFY_AQ_OPTICS_DATA 3
> #define SCLP_ERRNOTIFY_AQ_NVME_SMART_LOG 4
> +#define SCLP_ERRNOTIFY_AQ_ADAPTER_INITIALIZED 5
> +#define SCLP_ERRNOTIFY_AQ_RECOVERABLE_ERROR 6
> +#define SCLP_ERRNOTIFY_AQ_TELEMETRY_DATA 7
>
> #ifndef __ASSEMBLER__
> #include <linux/uio.h>
> diff --git a/drivers/s390/char/sclp_pci.c b/drivers/s390/char/sclp_pci.c
> index d61a7fc0dd61..b79ef7006e46 100644
> --- a/drivers/s390/char/sclp_pci.c
> +++ b/drivers/s390/char/sclp_pci.c
> @@ -99,6 +99,9 @@ static int sclp_pci_check_report(struct zpci_report_error_header *report)
> case SCLP_ERRNOTIFY_AQ_INFO_LOG:
> case SCLP_ERRNOTIFY_AQ_OPTICS_DATA:
> case SCLP_ERRNOTIFY_AQ_NVME_SMART_LOG:
> + case SCLP_ERRNOTIFY_AQ_ADAPTER_INITIALIZED:
> + case SCLP_ERRNOTIFY_AQ_RECOVERABLE_ERROR:
> + case SCLP_ERRNOTIFY_AQ_TELEMETRY_DATA:
> break;
> default:
> return -EINVAL;

LGTM.


Signed-off-by: Benjamin Block <bblock@xxxxxxxxxxxxx>

--
Best Regards, Benjamin Block / Linux on IBM Z Kernel Development
IBM Deutschland Research & Development GmbH / https://www.ibm.com/privacy
Vors. Aufs.-R.: Wolfgang Wendt / Geschäftsführung: David Faller
Sitz der Ges.: Ehningen / Registergericht: AmtsG Stuttgart, HRB 243294