Re: [PATCH v2 2/2] hwmon: (pmbus/vt7505) Add driver for Analog Devices MAX16545/MAX16550 and Volterra VT7505

[Guenter Roeck]

On 7/24/26 02:03, Krzysztof Kozlowski wrote:
> On Thu, Jul 23, 2026 at 04:43:59PM +0000, Pradhan, Sanman wrote:
> > diff --git a/drivers/hwmon/pmbus/Makefile b/drivers/hwmon/pmbus/Makefile
> > index 080d366809f3..daa4b49bc90f 100644
> > --- a/drivers/hwmon/pmbus/Makefile
> > +++ b/drivers/hwmon/pmbus/Makefile
> > @@ -75,6 +75,7 @@ obj-$(CONFIG_SENSORS_TPS53679)	+= tps53679.o
> >   obj-$(CONFIG_SENSORS_TPS546D24)	+= tps546d24.o
> >   obj-$(CONFIG_SENSORS_UCD9000)	+= ucd9000.o
> >   obj-$(CONFIG_SENSORS_UCD9200)	+= ucd9200.o
> > +obj-$(CONFIG_SENSORS_VT7505)	+= vt7505.o
> >   obj-$(CONFIG_SENSORS_XDP710)	+= xdp710.o
> >   obj-$(CONFIG_SENSORS_XDP720)	+= xdp720.o
> >   obj-$(CONFIG_SENSORS_XDPE122)	+= xdpe12284.o
> > diff --git a/drivers/hwmon/pmbus/vt7505.c b/drivers/hwmon/pmbus/vt7505.c
> > new file mode 100644
> > index 000000000000..a96abf75b1aa
> > --- /dev/null
> > +++ b/drivers/hwmon/pmbus/vt7505.c
> > @@ -0,0 +1,274 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> > +/*
> > + * Hardware monitoring driver for Analog Devices MAX16545/MAX16550 and
> > + * Volterra VT7505 PMBus controllers.
> > + *
> > + * SPDX-FileCopyrightText: Copyright Hewlett Packard Enterprise Development LP
>
> Tag is accepted but discouraged. Use standard copyright header.
>
> ...
>
>
> > +#define VT7505_MFR_PEAK_VIN		0xd1
> > +#define VT7505_MFR_PEAK_IOUT		0xd2
> > +#define VT7505_MFR_PEAK_PIN		0xd3
> > +#define VT7505_MFR_PEAK_TEMP		0xd4
> > +#define VT7505_MFR_CLEAR_PEAKS		0xd5
> > +#define VT7505_MFR_PEAK_VOUT		0xfd
> > +
> > +#define VT7505_RLOAD_DEFAULT		4750
> > +
> > +enum chips { max16550, vt7505 };
>
> You must adjust to upstream kernel style and such constants/defines are

No, you must not.

> UPPER CASE (I know there are antipatterns in existing drivers, though).

Not in the hardware monitoring subsystem, where the chips enumeration is
and always has been traditionally lower case.

Guenter