Re: [PATCH v3 07/17] media: i2c: os05b10: Add test pattern options

[Vladimir Zapolskiy]

On 7/18/26 23:08, Tarang Raval wrote:
> Add V4L2_CID_TEST_PATTERN support with multiple sensor test-pattern modes
> and program them via register 0x5080. Drop the fixed 0x5080 setting from
> the common register sequence so the pattern is selected only through the
> control.
>
> Removing the default write of 0x04 to register 0x5080 does not change the
> sensor's default behaviour. The value 0x04 leaves the test pattern enable
> bit (bit 7) cleared, so the sensor remains in normal streaming mode. It
> only programs the color bar style field, which is ignored unless a test
> pattern is enabled.
>
> Signed-off-by: Tarang Raval <tarang.raval@xxxxxxxxxxxxxxxxx>
> ---
>   drivers/media/i2c/os05b10.c | 55 +++++++++++++++++++++++++++++++++++--
>   1 file changed, 53 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/os05b10.c b/drivers/media/i2c/os05b10.c
> index 61c51844a91e..4e177eacc815 100644
> --- a/drivers/media/i2c/os05b10.c
> +++ b/drivers/media/i2c/os05b10.c
> @@ -102,6 +102,17 @@
>   
>   #define OS05B10_REG_FORMAT2		CCI_REG8(0x3821)
>   
> +#define OS05B10_REG_PRE_ISP_20_0       CCI_REG8(0x5080)
> +#define OS05B10_DISABLED               0x00
> +#define OS05B10_COLOR_BAR_1            0x80
> +#define OS05B10_COLOR_BAR_2            0x84
> +#define OS05B10_COLOR_BAR_3            0x88
> +#define OS05B10_COLOR_BAR_4            0x8c
> +#define OS05B10_COLOR_SQUARE           0x82
> +#define OS05B10_BW_SQUARE              0x92
> +#define OS05B10_TRANSPARENT_EFFECT     0xa0
> +#define OS05B10_ROLLING_BAR_EFFECT     0xc0

I'd rather split the values into 0x80 "enabled" mask and a specific
mode value, but this is also good as it is.

Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx>

--
Best wishes,
Vladimir