Re: [PATCH net-next v4 02/15] net: macb: unify device pointer naming convention

[Théo Lebrun]

Hello Nicolai,

On Sun Jul 19, 2026 at 12:32 PM CEST, Nicolai Buchwitz wrote:
> On 17.7.2026 21:48, Théo Lebrun wrote:
>> diff --git a/drivers/net/ethernet/cadence/macb.h 
>> b/drivers/net/ethernet/cadence/macb.h
>> index 2de56017ee0d..9857df5b57f0 100644
>> --- a/drivers/net/ethernet/cadence/macb.h
>> +++ b/drivers/net/ethernet/cadence/macb.h
>> @@ -1326,7 +1326,7 @@ struct macb {
>>  	struct clk		*tx_clk;
>>  	struct clk		*rx_clk;
>>  	struct clk		*tsu_clk;
>> -	struct net_device	*dev;
>> +	struct net_device	*netdev;
>
> Looks like you have missed the one in macb_free(), from commit 
> 27f575836cfe ("net:
> macb: drop in-flight Tx SKBs on close"):
>
> 	bp->dev->stats.tx_dropped += dropped;
>
> This breaks the build until patch 7 rewrites thatline, which breaks 
> bisection.

Argh. Next revision fixes it. Checked with

   git rebase --exec "make drivers/net/ethernet/cadence/"

Thanks,

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com