Re: [cocci] [1/36] coccinelle: misc: add cond_return_no_effect.cocci

[Markus Elfring]

>> …
>>> +++ b/scripts/coccinelle/misc/cond_return_no_effect.cocci
…
> Combining them with two separate metavariables would be okay,

Thanks that you can think a bit more about such a design variant.


>                                                               but I
> don't see much benefit in that change.

Further metavariables can eventually be shared for an SmPL rule.

How do you think about to avoid repeated search efforts by separate SmPL rules
(for the patch mode)?


>                                        So I'd prefer to stay existing
> form.
There are different SmPL coding style preferences involved.

Regards,
Markus