Re: [PATCH net-next v3 05/13] ax88179_178a: Use phylink in get/set_link_ksettings

[Andrew Lunn]

On Fri, Jul 24, 2026 at 05:06:07PM +0200, Birger Koblitz wrote:
> 
> Thanks for reviewing the patch-series, Andrew!
> On 7/24/26 15:38, Andrew Lunn wrote:
> > > +	if (data->phylink)
> > 
> > When did this appear? Am i missing a patch somewhere?
> > 
> 
> In [PATCH net-next v3 02/13] ax88179_178a: Add HW support for AX179A-based chips:+	struct mii_bus *mdio;
> +	struct phy_device *phydev;
> +	struct phylink *phylink;
> +	struct phylink_config phylink_config;
> But admittedly, this is a rather big patch, which I was unable to break apart
> due to in particular int ax88179a_bind() referencing most of the rest.

Ah, sorry. I took a quick look and assumed it was just adding new
devices.

Does it make sense to do the conversion without adding new devices?
That might make the patch smaller.

But i know converting to phylink often is one big patch. Sometimes you
can do some refactoring first to add helpers, but not always.

      Andrew