Re: [PATCH v5 3/3] hwmon: pmbus: add MPQ8646 driver

From: Markus Elfring

Date: Fri Jul 24 2026 - 12:57:29 EST



> +++ b/drivers/hwmon/pmbus/mpq8646.c
> @@ -0,0 +1,1253 @@

> +static int mpq8646_dbg_probe_smbus_rword(void *data, u64 val)
> +{

> + mutex_lock(&priv->mps_lock);
> + rc = i2c_smbus_read_word_data(priv->client, (u8)val);

> + mutex_unlock(&priv->mps_lock);
> + return 0;
> +}


Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&priv->mps_lock);”?
https://elixir.bootlin.com/linux/v7.2-rc4/source/include/linux/mutex.h#L253

Regards,
Markus