Re: [PATCH net-next v5 02/15] net: macb: unify device pointer naming convention

[Nicolai Buchwitz]

On 24.7.2026 17:29, Théo Lebrun wrote:
> Here are all device pointer variable permutations inside MACB:
>
>    struct device *dev;
>    struct net_device *dev;
>    struct net_device *ndev;
>    struct net_device *netdev;
>    struct pci_dev *pdev;              // inside macb_pci.c
>    struct phy_device *phy;
>    struct phy_device *phydev;
>    struct platform_device *pdev;
>    struct platform_device *plat_dev;  // inside macb_pci.c
>
> Unify to this convention:
>
>    struct device *dev;
>    struct net_device *netdev;
>    struct pci_dev *pci;
>    struct phy_device *phydev;
>    struct platform_device *pdev;
>
> Ensure nothing slipped through using ctags tooling:
>
> ⟩ ctags -o - --kinds-c='{local}{member}{parameter}' \
>     --fields='{typeref}' drivers/net/ethernet/cadence/* | \
>   awk -F"\t" '
>     $NF~/struct:.*(device|dev) / {print $NF, $1}' | \
>   sort -u
> typeref:struct:device * dev
> typeref:struct:in_device * idev        // ignored
> typeref:struct:net_device * netdev
> typeref:struct:pci_dev * pci
> typeref:struct:phy_device * phydev
> typeref:struct:platform_device * pdev
>
> Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx>
> ---

> [...]

Reviewed-by: Nicolai Buchwitz <nb@xxxxxxxxxxx>

Thanks
Nicolai