Re: [PATCH net-next v5 3/3] selftests/net: devmem.py: add check_rx_large_niov
From: Bobby Eshleman
Date: Fri Jul 24 2026 - 17:42:40 EST
On Fri, Jul 24, 2026 at 02:30:01PM -0700, Jakub Kicinski wrote:
> On Fri, 24 Jul 2026 14:04:24 -0700 Bobby Eshleman wrote:
> > On Tue, Jul 21, 2026 at 11:09:03AM -0700, Jakub Kicinski wrote:
> > > On Wed, 08 Jul 2026 15:55:06 -0700 Bobby Eshleman wrote:
> > > > +@ksft_disruptive
> > > > +def check_rx_large_niov(cfg) -> None:
> > > > + """Run the devmem RX test with rx-buf-size = 16 KiB."""
> > > > + run_rx_large_niov(cfg)
> > >
> > > Any idea why the devmem tests sprinkle disruptive everywhere?
> > > Disruptive means we take the link down, I don't think this test
> > > does that.
> >
> > Talked to Stan and he mentioned the original idea was not necessarily
> > just for link down, but any test that could be considered disruptive to
> > other tests, with the idea to eventually introduce some scheduling
> > (postpone disruptive until the end).
>
> Perhaps have such conversations on the list? IDK what Stan has in mind.
For sure.
@Stan, can you elaborate on the intent of @ksft_disruptive?
>
> > If we can get common agreement on its meaning, maybe I could submit
> > something into the documentation and update where its misused?
> >
> > I'll drop it from this patch since it doesn't bring down the link (and
> > seemingly no worries about check_rx_hds() tests not having it).