Re: [PATCH] serial: sc16is7xx: implement gpio get_direction() callback

From: Linus Walleij

Date: Fri Jul 24 2026 - 18:10:34 EST


On Thu, Jul 16, 2026 at 11:08 PM Hugo Villeneuve <hugo@xxxxxxxxxxx> wrote:

> From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
>
> It's strongly recommended for GPIO drivers to always implement the
> .get_direction() callback - even when the direction is tracked in
> software. The GPIO core emits a warning when the callback is missing
> and a user reads the direction of a line, e.g. via
> /sys/kernel/debug/gpio.
>
> Fixes: dfeae619d781 ("serial: sc16is7xx")
> Cc: stable@xxxxxxxxxx
> Signed-off-by: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>

Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>

Yours,
Linus Walleij