Re: [PATCH 1/3] Revert "i2c: qcom-cci: Remove unused struct member cci_clk_rate"
From: Andi Shyti
Date: Fri Jul 24 2026 - 18:59:59 EST
Hi Loic,
On Tue, Jul 21, 2026 at 04:58:19PM +0200, Loic Poulain wrote:
> This reverts commit b641af684fc28a07bee9c808eb6c433f9d9bcec6.
>
> The cci_clk_rate field is needed to enforce the correct CCI clock rate
> at probe time. The hw_params timing values are in clock ticks and were
> calibrated for a specific frequency per hardware variant, so running at
> the wrong rate would violate I2C timing specifications.
>
> Signed-off-by: Loic Poulain <loic.poulain@xxxxxxxxxxxxxxxx>
Does this revert need a Fixes tag? I haven't seen very often
reverts with Fixes tag, but it makes sense if they need to be
backported.
I'm going to take patch 1 and 2 already while we discuss patch 3
separately, but please let me know first if you agree adding the
Fixes tag.
Andi