Re: [PATCH net-next v3 2/3] net: dsa: mv88e6xxx: embedded PTP timestamp support

From: Jakub Kicinski

Date: Fri Jul 24 2026 - 19:49:44 EST


On Sun, 19 Jul 2026 15:30:54 +1000 Luke Howard wrote:
> + /* APPEND means the switch appended the time stamp as a 4-byte trailer
> + * (not all switches support this). Any other non-zero value is the byte
> + * offset past the start of the PTP common header at which the switch
> + * overwrote the time stamp in place (e.g. the reserved header bytes).
> + */
> + if (arr_ts_mode == MV88E6XXX_PTP_ARR_TS_MODE_APPEND && skb->len >= 4) {
> + if (skb_linearize(skb))
> + return false;
> +
> + *ns = (u64)get_unaligned_be32(skb_tail_pointer(skb) - 4);
> + if (pskb_trim_rcsum(skb, skb->len - 4))
> + return false;

The append mode would extend the frame, and possibly run afoul the MTU
on the conduit AFAIU? Since neither implemented chip uses this it's
both dead code and questionable. Let's remove it.