Re: [PATCH v2] drm/bridge: ps8640: propagate AUX transfer register errors

[Doug Anderson]

Hi,

On Wed, Jul 22, 2026 at 7:38 PM Pengpeng Hou <pengpeng@xxxxxxxxxxx> wrote:
>
> ps8640_aux_transfer_msg() programs the AUX address registers, starts the
> AUX transfer, waits for SWAUX_SEND to clear, and reads the AUX status
> register. Several of those regmap operations have return values, but the
> function only checks a stale ret after the status read.
>
> Propagate failures from the address write, transfer start, completion
> poll, and status read. This avoids returning a transfer length when the
> bridge register transaction or AUX completion wait failed.
>
> Fixes: 13afcdd7277e ("drm/bridge: parade-ps8640: Add support for AUX channel")
> Signed-off-by: Pengpeng Hou <pengpeng@xxxxxxxxxxx>
> ---
> Changes since v1: https://lore.kernel.org/all/20260623060635.16064-1-pengpeng@xxxxxxxxxxx/
> - include the AUX address and length in the address-write diagnostic
> - describe poll failures without assuming that every error is a timeout
> - add the Fixes tag suggested by Doug
> - rebase onto the current drm-misc-next tree
>
>  drivers/gpu/drm/bridge/parade-ps8640.c | 27 +++++++++++++++++++++------
>  1 file changed, 21 insertions(+), 6 deletions(-)

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

Assuming nothing else comes up, I'll plan to apply to drm-misc-fixes next week.

-Doug