Re: [PATCH 1/2] riscv: dts: spacemit: Add enough deassert time for the PHY on PICO ITX

[Inochi Amaoto]

On Fri, Jul 10, 2026 at 10:38:04PM +0000, Yixun Lan wrote:
> Hi Inochi,
> 
> On 14:33 Fri 10 Jul     , Inochi Amaoto wrote:
> > RTL8211F require at least 50ms deassert to guarantee the register
> > access, 10ms is only enough for the PHY reset.
> > 
> IMO, it's kind of too trivial to split into two separate patches,
> while duplicating the commit message
> 

For backport, I suggest keeping two patches, so it can be backported
in a more clear way

Regards,
Inochi

> > Fixes: 74657a376960 ("riscv: dts: spacemit: Add ethernet device for K3")
> If you agree to squash the patches, then should be fine to put both Fixes here
> also suggest to adjust title to be more simple and explict
> riscv: dts: spacemit: Increase deassert time for PHY RTL8211F
> 
> > Signed-off-by: Inochi Amaoto <inochiama@xxxxxxxxx>
> the fix looks good to me, so
> Reviewed-by: Yixun Lan <dlan@xxxxxxxxxx>
> 
> > ---
> >  arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> > index 1eb5abbc61f9..b2a7d2d0d3a8 100644
> > --- a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> > +++ b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> > @@ -200,7 +200,7 @@ phy0: phy@1 {
> >  			reg = <1>;
> >  			reset-gpios = <&gpio 0 15 GPIO_ACTIVE_LOW>;
> >  			reset-assert-us = <10000>;
> > -			reset-deassert-us = <10000>;
> > +			reset-deassert-us = <50000>;
> >  		};
> >  	};
> >  };
> > -- 
> > 2.55.0
> > 
> > 
> 
> -- 
> Yixun Lan (dlan)