Re: [PATCH] Input: psxpad-spi - set driver data before use

[Dmitry Torokhov]

Hi Linmao,

On Tue, Jul 21, 2026 at 01:55:51PM +0800, Linmao Li wrote:
> psxpad_spi_suspend() retrieves the controller state with
> spi_get_drvdata(), but probe never stores it, so suspend dereferences a
> NULL pointer. Store it during probe.
> 
> Fixes: 8be193c7b1f4 ("Input: add support for PlayStation 1/2 joypads connected via SPI")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Linmao Li <lilinmao@xxxxxxxxxx>
> ---
>  drivers/input/joystick/psxpad-spi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/joystick/psxpad-spi.c b/drivers/input/joystick/psxpad-spi.c
> index f902a56d011f..b1ab2486bb0d 100644
> --- a/drivers/input/joystick/psxpad-spi.c
> +++ b/drivers/input/joystick/psxpad-spi.c
> @@ -301,6 +301,7 @@ static int psxpad_spi_probe(struct spi_device *spi)
>  	/* input poll device settings */
>  	pad->idev = idev;
>  	pad->spi = spi;
> +	spi_set_drvdata(spi, pad);

I moved the assignment to the end of probe and applied, thank you.

-- 
Dmitry