Re: [PATCH v2 2/2] Input: st-keyscan: Improve probe error handling

[Dmitry Torokhov]

On Tue, Jul 21, 2026 at 09:20:30AM +0700, Bui Duc Phuc wrote:
> Hi Dmitry,
> 
> Thank you for your feedback.
> 
> > > Use dev_err_probe() for devm_clk_get() so deferred probe errors are
> > > handled correctly.
> >
> > Same here: in what way the does existing code handle deferred probe
> > incorrectly?
> >
> This is the same case as the previous patch. The current code uses dev_err(),
> which logs an error message even when devm_clk_get() returns -EPROBE_DEFER.
> Since the probe will be retried later, this leads to unnecessary log spam.
> Link to previous discussion for reference:
> https://lore.kernel.org/all/CAABR9nHHe1AzWmqhV0d5p87qfSsBk2O7bYj-Weowyr=99wtNNA@xxxxxxxxxxxxxx/
> 
> Would you like me to send a v3 updating the commit message to be clearer,
> such as: "Use dev_err_probe() for devm_clk_get() to prevent log spam
> when probe returns -EPROBE_DEFER.""
> or keep the current patch as is?

Yes, please, since the handling of deferrals was not broken. We just had
some harmless extra logging.

Thanks.

-- 
Dmitry