Re: [PATCH v3 0/3] drm/nouveau: Fix WARN_ON() from missing blend modes

[Dave Airlie]

On Tue, 21 Jul 2026 at 07:51, Lyude Paul <lyude@xxxxxxxxxx> wrote:
>
> Recently a change went into the kernel to ensure that drivers which
> expose color formats which have alpha channels. This would cause nouveau
> to hit a WARN_ON when setting up cursors, since they do support blending
> - but we never bothered trying to hook up the controls for it to
> nouveau.
>
> This fixes the issue by ensuring that nouveau always exposes a blend
> mode for any planes with alpha channels, regardless of whether or not we
> have control of the blend mode hooked up. If someone wants to add
> control for this in the future as well, it should be fairly easy to hook
> up with this.
>
> Previous version:
>         https://patchwork.freedesktop.org/api/1.0/series/170773/revisions/1/mbox/

For the series,

Reviewed-by: Dave Airlie <airlied@xxxxxxxxxx>

>
> Lyude Paul (3):
>   drm/nouveau/kms/nv50-: Add .blend_modes to nv50_wndw_func
>   drm/nouveau/kms/nv50-: Introduce nv50_wndw_default_state()
>   drm/nouveau/kms/nv50-: Unconditionally create blend_mode prop for
>     wndws
>
>  drivers/gpu/drm/nouveau/dispnv50/base.h     |  6 ++++
>  drivers/gpu/drm/nouveau/dispnv50/base507c.c |  1 +
>  drivers/gpu/drm/nouveau/dispnv50/base827c.c |  1 +
>  drivers/gpu/drm/nouveau/dispnv50/base907c.c |  1 +
>  drivers/gpu/drm/nouveau/dispnv50/curs507a.c |  3 ++
>  drivers/gpu/drm/nouveau/dispnv50/disp.c     |  4 +++
>  drivers/gpu/drm/nouveau/dispnv50/wndw.c     | 40 +++++++++++++++++----
>  drivers/gpu/drm/nouveau/dispnv50/wndw.h     | 11 ++++++
>  drivers/gpu/drm/nouveau/dispnv50/wndwc37e.c |  1 +
>  drivers/gpu/drm/nouveau/dispnv50/wndwc57e.c |  1 +
>  drivers/gpu/drm/nouveau/dispnv50/wndwc67e.c |  1 +
>  drivers/gpu/drm/nouveau/dispnv50/wndwca7e.c |  1 +
>  12 files changed, 64 insertions(+), 7 deletions(-)
>
>
> base-commit: b0a652436b892eb9a036a031b33099dca036faaa
> --
> 2.55.0
>