Re: [PATCH] hwrng: stm32 - Fix runtime PM cleanup on registration failure

[Linus Walleij]

Hi Can,

thanks for your patch!

On Sat, Jul 18, 2026 at 5:30 AM Can Peng <pengcan@xxxxxxxxxx> wrote:

> stm32_rng_probe() enables autosuspend and runtime PM before registering the
> hwrng. If devm_hwrng_register() fails, probe returns with runtime PM left
> enabled and autosuspend still selected.
>
> The remove callback also only disables runtime PM and does not undo
> pm_runtime_use_autosuspend().
>
> Use devm_pm_runtime_enable() so runtime PM is unwound automatically on
> probe failure and driver detach. Since the managed cleanup also disables
> runtime PM,drop the remove callback.
>
> Fixes: c6a97c42e399 ("hwrng: stm32 - add support for STM32 HW RNG")
> Cc: stable@xxxxxxxxxxxxxxx

Ah come on, it's not that serious.

> Signed-off-by: Can Peng <pengcan@xxxxxxxxxx>

Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>

Yours,
Linus Walleij