Re: [PATCH] drm/panel-edp: Add BOE NE140QDM-NX2
From: Weiji Wang
Date: Sat Jul 25 2026 - 08:11:22 EST
Hi there,
On 7/24/26 23:24, Doug Anderson wrote:
This is not sorted properly. 0x0af2 does not belong between 0x0b1e and 0x0b34.
...I could fix that when applying, but I also have a question: do you
have access to the datasheet of this panel, or are you just guessing
the right timing by looking at the nearby panels? I assume you have
this panel yourself for testing and confirm it seems to work OK.
The datasheet is taken from Panelook. I have to mention that enable delay
is not directly available in the datasheet, only (T4+T5+T6+T8)-min is
given.
I'm not really familiar with eDP panels, so I'm not sure if using
'prepare_to_enable' instead of 'enable' will break anything on devices
without HPD enabled. However, appearently (T4+T5+T6+T8)-min is greater
than (T6-min + max(T7-max, T8-min)), so I believe that setting 'enable'
to (T4+T5+T6+T8)-min is conservative enough.
Is it proper to switch to 'delay_200_500_p2e80' (use 'prepare_to_enable'
instead)? If so, I would change it and also the panel entry sorting.