Re: [PATCH v10 2/7] mfd: Add driver for ASUS Transformer embedded controller

[Svyatoslav Ryhel]

чт, 23 лип. 2026 р. о 09:25 Uwe Kleine-König
<u.kleine-koenig@xxxxxxxxxxxx> пише:
>
> Hello,
>
> On Tue, Jul 21, 2026 at 12:52:28PM +0300, Svyatoslav Ryhel wrote:
> > From: Michał Mirosław <mirq-linux@xxxxxxxxxxxx>
> >
> > Support Nuvoton NPCE795-based ECs as used in Asus Transformer TF201,
> > TF300T, TF300TG, TF300TL and TF700T pad and dock, as well as TF101 dock
> > and TF600T, P1801-T and TF701T pad. This is a glue driver handling
> > detection and common operations for EC's functions.
> >
> > Co-developed-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx>
> > Signed-off-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx>
> > Signed-off-by: Michał Mirosław <mirq-linux@xxxxxxxxxxxx>
>
> Documentation/process/submitting-patches.rst has:
>
>         [...] the ordering of Signed-off-by: tags should reflect the
>         chronological history of the patch insofar as possible [...]
>
> So your S-o-b should be last when you submit a patch.
>
> > +#include <linux/i2c.h>
> > [...]
> > +#include <linux/mod_devicetable.h>
>
> <linux/mod_devicetable.h> will go away soon. Please rely on
> <linux/i2c.h> to provide a definition of struct of_device_id and drop
> the #include of mod_devicetable.h.
>
> > +static const struct of_device_id asus_ec_match[] = {
> > +     {
> > +             .compatible = "asus,sl101-ec-dock",
> > +             .data = &asus_ec_sl101_dock_data
> > +     }, {
> > +             .compatible = "asus,tf101-ec-dock",
> > +             .data = &asus_ec_tf101_dock_data
> > +     }, {
> > +             .compatible = "asus,tf201-ec-pad",
> > +             .data = &asus_ec_tf201_pad_data
> > +     }, {
> > +             .compatible = "asus,tf600t-ec-pad",
> > +             .data = &asus_ec_tf600t_pad_data
> > +     },
> > +     { /* sentinel */ }
> > +};
>
> Trailing comma after the assignments to .data please.
>

Sure, but out of curiosity, why in this case you ask for trailing
comma and if entries are in one line, you don't.

> Best regards
> Uwe