Re: [PATCH v2] fbdev: replace dead select with dependency

[Helge Deller]

On 7/23/26 14:28, Julian Braha wrote:
> 'select' does not work on config options in a 'choice', so currently it is
> possible to enable FB_MB862XX_LIME without FB_LITTLE_ENDIAN.
>
> We cannot replace the 'select FB_LITTLE_ENDIAN' without also changing
> FB_FOREIGN_ENDIAN from 'select' to 'depends on', otherwise we will get
> a recursive dependency.
>
> Since the default choice is FB_BOTH_ENDIAN, let's use:
> 'depends on FB_LITTLE_ENDIAN || FB_BOTH_ENDIAN'
> to avoid breaking defconfig.
>
> This dead select was found by kconfirm, a static analysis tool for Kconfig.
>
> Suggested-by: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: Julian Braha <julianbraha@xxxxxxxxx>
> ---
> Changes since v1: support the default FB_BOTH_ENDIAN
> Link:
> https://lore.kernel.org/all/20260722220023.196029-1-julianbraha@xxxxxxxxx/
> ---
>   drivers/video/fbdev/Kconfig | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
applied.

Thanks!
Helge