Re: [PATCH 1/2] riscv: dts: spacemit: Fix phy id check for the phy on pico-itx board

[Inochi Amaoto]

On Sat, Jul 25, 2026 at 05:57:42PM +0200, Andrew Lunn wrote:
> On Sat, Jul 25, 2026 at 08:58:02AM +0800, Inochi Amaoto wrote:
> > Current phy framework can not reinit the phy correctly, as it will
> > assert the phy reset GPIO so the phy id can not be readed. Setting
> > the phy id of board pico-itx manually so the phy id dectection can
> > be skipped.
> > 
> > Fixes: 74657a376960 ("riscv: dts: spacemit: Add ethernet device for K3")
> > Reported-by: E Shattow <e@xxxxxxxxxxxx>
> > Reported-by: Inochi Amaoto <inochiama@xxxxxxxxx>
> > Closes: https://lore.kernel.org/netdev/20260712045233.800748-1-inochiama@xxxxxxxxx
> > Signed-off-by: Inochi Amaoto <inochiama@xxxxxxxxx>
> > Tested-by: E Shattow <e@xxxxxxxxxxxx>
> > ---
> >  arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> > index b2a7d2d0d3a8..b9d2de878f38 100644
> > --- a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> > +++ b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> > @@ -196,7 +196,8 @@ &eth0 {
> >  
> >  	mdio {
> >  		phy0: phy@1 {
> > -			compatible = "ethernet-phy-ieee802.3-c22";
> > +			compatible = "ethernet-phy-id001c.c916",
> > +				     "ethernet-phy-ieee802.3-c22";
> 
> There was a patch recently from one of the DT Maintainers removing the
> -c22 compatible when there was a specific PHY ID. I did not look into
> why. Does this pass all the binding tool checks?
> 

Thanks for this mention, I have found the patch link.
https://lore.kernel.org/netdev/20260323194803.GA1241974-robh@xxxxxxxxxx/

It seems like this patch is not merge at now, but I am fine to
send a new version for the incoming change.

Regards,
Inochi