Re: [PATCH v3 1/5] mm/rmap: convert page -> folio for hwpoison checks

[Dev Jain]

On 26/07/26 7:37 am, Andrew Morton wrote:
> On Sat, 25 Jul 2026 13:06:25 +0530 Dev Jain <dev.jain@xxxxxxx> wrote:
> 
>>>> @@ -2204,7 +2205,11 @@ static bool try_to_unmap_one(struct folio *folio, struct vm_area_struct *vma,
>>>>  		/* Update high watermark before we lower rss */
>>>>  		update_hiwater_rss(mm);
>>>>
>>>> -		if (PageHWPoison(subpage) && (flags & TTU_HWPOISON)) {
>>>> +		/*
>>>> +		 * With TTU_HWPOISON, we only expect small folios or hugetlb
>>>> +		 * folios here for now.
>>>> +		 */
>>>> +		if (folio_test_hwpoison(folio) && (flags & TTU_HWPOISON)) {
>>>
>>> As per v2 discussion, I feel this could be tightened up, maybe something like:
>>>
>>> 		/* unmap_poisoned_folio() only refs order-0 or hugetlb folios */
>>>
>>
>> I can do this. But note that this series is in mm-unstable already - what should
>> I base the v4 on?
> 
> Ordinarily basing on latest Linus works.  But this patchset has ~450
> patches ahead of it and a quick trial merge wasn't promising.
> 
> I could drop the v3 series so you can base on next mm-new, please lmk.
> 
> Or
> 
> mm> git log --oneline | grep "mm/rmap: convert page -> folio for hwpoison checks"
> bb2f8a7eb126 mm/rmap: convert page -> folio for hwpoison checks
> mm> git checkout bb2f8a7eb126^

This one looks good, I'll do this.

I'll wait for Lorenzo's (or any others) potential review comments for two days
before I send this.