Re: [PATCH v16 7/7] spi: pxa2xx: rename local status variable to ret
From: Shih-Yuan Lee (FourDollars)
Date: Sun Jul 26 2026 - 07:26:48 EST
On Tue, Jul 21, 2026 at 3:56 AM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxx> wrote:
>
> On Tue, Jul 21, 2026 at 12:21:16AM +0800, Shih-Yuan Lee wrote:
> > Rename the return value variable name from 'status' to 'ret' in the
> > pxa2xx_spi_probe(), pxa2xx_spi_suspend(), pxa2xx_spi_resume(), and
> > pxa2xx_spi_runtime_resume() functions to conform to standard Linux kernel
> > coding conventions.
>
Hi Andy,
> It makes a ping-pong style of changes: Previous patches add more status uses
> and moves, and so on. Instead, this patch should go before all that.
Agreed. I have reordered the patch series for the next version so that
"spi: pxa2xx: rename local status variable to ret" is placed near the
front, eliminating all ping-pong diff churn.
Thanks,
Shih-Yuan