Re: Re: [RFC PATCH 6.6.y] atm: he: kill tasklet before releasing queues
From: Greg KH
Date: Sun Jul 26 2026 - 08:52:06 EST
On Sun, Jul 26, 2026 at 08:30:41PM +0800, 许红岩 wrote:
>
>
> Thanks greg k-h
> I do not have the HE hardware, so the patch has only been build-tested and
> reviewed against the teardown path.
Then why create these patches at all? What is driving the need for
them?
> Given that the driver has already been removed upstream, I agree that deleting
> it from maintained stable trees would be cleaner if that is acceptable for
> stable. I sent the small fix only because the driver is still present there
> and I did not want to backport the much larger ATM removal commit.
But if you don't have the hardware, and don't use this driver, why do
this at all? Why even look at older kernel versions for stuff that is
not used?
> I can prepare a stable-only removal patch for
> the HE driver instead, or backport the relevant upstream removal pieces if that
> is preferred.
As no one uses these drivers, due to lack of hardware and the like, they
can't be abused at all, so just leave them alone for older kernels, no
need to delete them as they do not cause any additional burden there at
all.
thanks,
greg k-h