Re: [PATCH 22/31] swim: Remove pointless mode0 register write

[Laurent Vivier]

Le 16/07/2026 à 12:02, Finn Thain a écrit :
> This write has no effect so remove it. (If side == 0 then no mode bit gets
> cleared. If side == 1 then mode bit 0 gets cleared but that's pointless
> because that bit is already clear here.)
>
> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxx>
> ---
>   drivers/block/swim.c | 1 -
>   1 file changed, 1 deletion(-)

Reviewed-by: Laurent Vivier <laurent@xxxxxxxxx>

> diff --git a/drivers/block/swim.c b/drivers/block/swim.c
> index 44fe7a79059c..0bab7ed3daa8 100644
> --- a/drivers/block/swim.c
> +++ b/drivers/block/swim.c
> @@ -467,7 +467,6 @@ static inline int swim_read_sector(struct floppy_state *fs,
>   
>   	swim_track(fs, track);
>   	swim_head(base, side);
> -	swim_write(base, mode0, side);
>   
>   	local_irq_save(flags);
>   	for (i = 0; i < 36; i++) {