Re: [PATCH 1/3] Revert "i2c: qcom-cci: Remove unused struct member cci_clk_rate"

[Andi Shyti]

Hi Vladimir,

> > > The cci_clk_rate field is needed to enforce the correct CCI clock rate
> > > at probe time. The hw_params timing values are in clock ticks and were
> > > calibrated for a specific frequency per hardware variant, so running at
> > > the wrong rate would violate I2C timing specifications.
> > > 
> > > Signed-off-by: Loic Poulain <loic.poulain@xxxxxxxxxxxxxxxx>
> > 
> > Does this revert need a Fixes tag? I haven't seen very often
> > reverts with Fixes tag, but it makes sense if they need to be
> > backported.

There is a Requires tag (or similar, I don't remember).

> > I'm going to take patch 1 and 2 already while we discuss patch 3
> > separately, but please let me know first if you agree adding the
> > Fixes tag.
> > 
> 
> please put all commits from this series on hold due to my last finding:
> 
> https://lore.kernel.org/linux-arm-msm/8d20f3ab-696e-40a4-a05a-688779299071@xxxxxxxxxx

Thanks Vladimir!

Andi