Re: [PATCH v2 03/13] iio: chemical: Remove redundant dev_err()/dev_err_probe()

[Jonathan Cameron]

On Sun, 26 Jul 2026 21:08:30 +0100
Jonathan Cameron <jic23@xxxxxxxxxx> wrote:

> On Sat, 25 Jul 2026 20:16:15 -0300
> Gustavo Silva <gustavograzs@xxxxxxxxx> wrote:
> 
> > On Fri, Jul 24, 2026 at 11:03:38AM +0800, Pan Chuang wrote:  
> > > Since commit
> > > 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
> > > devm_request_irq() and devm_request_threaded_irq() automatically log
> > > detailed error messages on failure. Remove the now-redundant
> > > driver-specific dev_err() and dev_err_probe() calls.
> > > 
> > > Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
> > > ---
> > >  drivers/iio/chemical/ccs811.c      | 4 +---
> > >  drivers/iio/chemical/ens160_core.c | 2 +-
> > >  drivers/iio/chemical/scd30_core.c  | 2 +-
> > >  3 files changed, 3 insertions(+), 5 deletions(-)
> > >     
> > 
> > Reviewed-by: Gustavo Silva <gustavograzs@xxxxxxxxx> # for ens160
> >   
> 
> For some reason b4 is adding a review from Andy to this one
> that I can't find either locally or on the list (not for v1
> or this).  I've edited it out by hand.
> 
> Maxwell did give a tag though on v1 so I've kept that.
Ah. Andy did give it, and the author should have picked it up
after following the condition attached in reply to v1.

> 
> Thanks,
> 
> Jonathan
>