[PATCH v3 2/5] nfc: s3fwrn5: use the "s3fwrn5_i2c" string literal directly
From: Jorijn van der Graaf
Date: Sun Jul 26 2026 - 18:25:33 EST
The S3FWRN5_I2C_DRIVER_NAME define is an indirection for a string that
is fixed ABI (the driver name) and only used within this file. Spell
the string out at its three users and drop the define.
Suggested-by: David Heidelberg <david@xxxxxxx>
Assisted-by: Claude:claude-fable-5
Signed-off-by: Jorijn van der Graaf <jorijnvdgraaf@xxxxxxxxxxxxx>
---
drivers/nfc/s3fwrn5/i2c.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/nfc/s3fwrn5/i2c.c b/drivers/nfc/s3fwrn5/i2c.c
index cb73993446e0..c528c085b43e 100644
--- a/drivers/nfc/s3fwrn5/i2c.c
+++ b/drivers/nfc/s3fwrn5/i2c.c
@@ -16,8 +16,6 @@
#include "phy_common.h"
-#define S3FWRN5_I2C_DRIVER_NAME "s3fwrn5_i2c"
-
struct s3fwrn5_i2c_phy {
struct phy_common common;
struct i2c_client *i2c_dev;
@@ -186,7 +184,7 @@ static int s3fwrn5_i2c_probe(struct i2c_client *client)
ret = devm_request_threaded_irq(&client->dev, phy->i2c_dev->irq, NULL,
s3fwrn5_i2c_irq_thread_fn, IRQF_ONESHOT,
- S3FWRN5_I2C_DRIVER_NAME, phy);
+ "s3fwrn5_i2c", phy);
if (ret)
goto s3fwrn5_remove;
@@ -205,7 +203,7 @@ static void s3fwrn5_i2c_remove(struct i2c_client *client)
}
static const struct i2c_device_id s3fwrn5_i2c_id_table[] = {
- { .name = S3FWRN5_I2C_DRIVER_NAME },
+ { .name = "s3fwrn5_i2c" },
{ }
};
MODULE_DEVICE_TABLE(i2c, s3fwrn5_i2c_id_table);
@@ -218,7 +216,7 @@ MODULE_DEVICE_TABLE(of, of_s3fwrn5_i2c_match);
static struct i2c_driver s3fwrn5_i2c_driver = {
.driver = {
- .name = S3FWRN5_I2C_DRIVER_NAME,
+ .name = "s3fwrn5_i2c",
.of_match_table = of_s3fwrn5_i2c_match,
},
.probe = s3fwrn5_i2c_probe,
--
2.55.0