RE: [PATCH net v4 3/3] net: ethernet: oa_tc6: Disabled tx queues when disable_traffic is set

[Selvamani Rajagopal]

Thanks for reviewing. 

> -----Original Message-----
> From: Parthiban Veerasooran <parthiban.veerasooran@xxxxxxxxxxxxx>
> Subject: Re: [PATCH net v4 3/3] net: ethernet: oa_tc6: Disabled tx queues when
> disable_traffic is set
> 
> 
> Imperative mood for the subject: "Disable tx queues when disable_traffic
> is set" (netdev convention).

Done

> 
> > disable_traffic is set. Carrier is also marked off
> "Carrier is also marked off" contradicts both the code and your own v4
> changelog: the patch only adds netif_tx_disable(), there is no
> netif_carrier_off(), and v4 says you reverted the carrier change. Please
> drop this sentence — the message currently describes behavior the patch
> doesn't implement.

Thanks for catching. Dropped the reference to carrier

> >
> --- is missing

added


> > changes in v4
> > - Reverted the the statement that turned carrier off on
> typo

Removed the excess "the". Usually check_patch catches this kind of typos.
May be it doesn't check the commit messages

.
> > disble_traffic, as it may have side effects
> typo.

Fixed the typo in "disable"

> > changes in v3