Re: [PATCHv2] crypto: cesa: check for sram_dma error

[Herbert Xu]

On Fri, Jul 17, 2026 at 03:58:31PM -0700, Rosen Penev wrote:
> dma_map_resource() might fail. In such a case, don't call
> dma_unmap_resource()
> 
> Fixes: 37d728f76c41 ("crypto: marvell/cesa - Fix DMA API misuse")
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> ---
>  v2: use dma_mapping_error(). Fix Fixes tag.
>  drivers/crypto/marvell/cesa/cesa.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

I think it would be better to fix mv_cesa_probe to not call the
cleanup functions on uninitialised engines.

err_cleanup:
	for (i = 0; i < XXX; i++)
		mv_cesa_put_sram(pdev, i);

So replace XXX here with one past the last index that was successfully
initialised.

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt