Re: [PATCH v4 0/6] Shikra: Add DT support for ICE, RNG and QCE

[Herbert Xu]

On Tue, Jul 14, 2026 at 03:35:11PM +0530, Kuldeep Singh wrote:
> This patch series enables SDHC ICE, RNG and QCE support on Shikra,
> aligned with how similar support is modeled on other Qualcomm platforms.
> 
> These DT and dt-bindings updates were previously posted as three
> separate series. Based on review feedback, they are grouped here as one
> crypto-focused series.
> Previous threads:
> QCE: https://lore.kernel.org/lkml/20260515-shikra_qcrypto-v1-0-80f07b345c29@xxxxxxxxxxxxxxxx/
> RNG: https://lore.kernel.org/lkml/20260514-shikra_rng-v1-0-4ea721a1429a@xxxxxxxxxxxxxxxx/
> ICE: https://lore.kernel.org/lkml/20260515-shikra_ice_ufs-v2-0-2724a54339db@xxxxxxxxxxxxxxxx/
> 
> Prequisite patchsets are already merged so no longer tracking.
> 
> Validation:
> - ICE: driver probe at boot
> - QCE: kcapi tests and driver probe
> - RNG: validated using rngutils
> - DT: validated shikra-cqs-evk.dtb with dt_binding_check and CHECK_DTBS=y
> 
> Signed-off-by: Kuldeep Singh <kuldeep.singh@xxxxxxxxxxxxxxxx>
> ---
> Changes in v4:
> - Update Patch 1/6 commit message to accustom hawi special case.
> - Collects tags(Krzysztof)
> - Link to v3: https://patch.msgid.link/20260706-b4-shikra_crypto_changse-v3-0-23b4c2054227@xxxxxxxxxxxxxxxx
> 
> Changes in v3:
> - Fix commit messages.
> - Collect Ack and Reviewed-by tags.
> - Link to v2: https://patch.msgid.link/20260702-b4-shikra_crypto_changse-v2-0-66173f2f28b3@xxxxxxxxxxxxxxxx
> 
> Changes in v2:
> - Add fix in ice bindings to specify 2 clocks defauly for non-legacy Soc
>   compatibles.
> - Update commit messages.
> - Link to v1: https://patch.msgid.link/20260521-shikra_crypto_changse-v1-0-0154cc9cc0de@xxxxxxxxxxxxxxxx/
> 
> To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> To: "David S. Miller" <davem@xxxxxxxxxxxxx>
> To: Rob Herring <robh@xxxxxxxxxx>
> To: Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>
> To: Conor Dooley <conor+dt@xxxxxxxxxx>
> To: Bjorn Andersson <andersson@xxxxxxxxxx>
> To: Kuldeep Singh <kuldeep.singh@xxxxxxxxxxxxxxxx>
> To: Harshal Dev <harshal.dev@xxxxxxxxxxxxxxxx>
> To: Vinod Koul <vkoul@xxxxxxxxxx>
> To: Bartosz Golaszewski <brgl@xxxxxxxxxx>
> To: Konrad Dybcio <konradybcio@xxxxxxxxxx>
> To: Frank Li <Frank.Li@xxxxxxxxxx>
> To: Andy Gross <agross@xxxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> Cc: linux-arm-msm@xxxxxxxxxxxxxxx
> Cc: linux-crypto@xxxxxxxxxxxxxxx
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: dmaengine@xxxxxxxxxxxxxxx
> 
> ---
> Kuldeep Singh (6):
>       dt-bindings: crypto: qcom,inline-crypto-engine: Fix legacy/new SoC strictness split
>       dt-bindings: crypto: qcom,inline-crypto-engine: Document Shikra ICE
>       dt-bindings: crypto: qcom,prng: Document Shikra TRNG
>       dt-bindings: crypto: qcom-qce: Document the Shikra crypto engine
>       dt-bindings: dma: qcom,bam-dma: Increase iommus maxItems to 7
>       arm64: dts: qcom: shikra: Add ICE, TRNG and QCE nodes
> 
>  .../bindings/crypto/qcom,inline-crypto-engine.yaml | 27 +++++++----
>  .../devicetree/bindings/crypto/qcom,prng.yaml      |  1 +
>  .../devicetree/bindings/crypto/qcom-qce.yaml       |  1 +
>  .../devicetree/bindings/dma/qcom,bam-dma.yaml      |  2 +-
>  arch/arm64/boot/dts/qcom/shikra.dtsi               | 52 ++++++++++++++++++++++
>  5 files changed, 73 insertions(+), 10 deletions(-)
> ---
> base-commit: 49362394dad7df66c274c867a271394c10ca2bb8
> change-id: 20260701-b4-shikra_crypto_changse-f2d6d5bf04b5

Patches 1-4 applied.  Thanks.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt