Re: [PATCH bpf-next v2] bpf: Log error code on trampoline unlink failure

[Leon Hwang]

On 27/7/26 10:31, xu.xin16@xxxxxxxxxx wrote:
[...]
>>>
>>
>> Would it be better to include this multi_detach() one?
>>
>>         WARN_ON_ONCE(__bpf_trampoline_unlink_prog(&mnode->node, mnode->trampoline,
>>                     NULL, &trampoline_multi_ops, data));
>>
> 
> Sure, what about moving WARNing into __bpf_trampoline_unlink_prog and then the failures of
> __bpf_trampoline_unlink_prog everywhere will be logged.

No. I think it's callers' responsibility to log warning.

Thanks,
Leon