Re: [PATCH v2 1/6] powerpc/xive: remove dead NULL check after GFP_NOFAIL allocation

[Mukesh Kumar Chaurasiya]

On Fri, Jul 24, 2026 at 10:28:46AM +0800, Gou Hao wrote:
> kzalloc_objs with the __GFP_NOFAIL flag will never return NULL, so the
> subsequent NULL check is unreachable dead code. Remove it.
> 
> Signed-off-by: Gou Hao <gouhao@xxxxxxxxxxxxx>
> Reviewed-by: Wentao Guan <guanwentao@xxxxxxxxxxxxx>
> Reviewed-by: jiazhenyuan <jiazhenyuan@xxxxxxxxxxxxx>
> ---
>  arch/powerpc/sysdev/xive/common.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/arch/powerpc/sysdev/xive/common.c b/arch/powerpc/sysdev/xive/common.c
> index dadd1f46ec939..f2904a5c2b7bf 100644
> --- a/arch/powerpc/sysdev/xive/common.c
> +++ b/arch/powerpc/sysdev/xive/common.c
> @@ -1134,9 +1134,6 @@ static int __init xive_init_ipis(void)
>  
>  	xive_ipis = kzalloc_objs(*xive_ipis, nr_node_ids,
>  				 GFP_KERNEL | __GFP_NOFAIL);
> -	if (!xive_ipis)
> -		goto out_free_domain;
> -
>  	for_each_node(node) {
>  		struct xive_ipi_desc *xid = &xive_ipis[node];
>  		struct xive_ipi_alloc_info info = { node };
> @@ -1158,7 +1155,7 @@ static int __init xive_init_ipis(void)
>  
>  out_free_xive_ipis:
>  	kfree(xive_ipis);
> -out_free_domain:
> +	xive_ipis = NULL;
>  	irq_domain_remove(ipi_domain);
>  out_free_fwnode:
>  	irq_domain_free_fwnode(fwnode);
> -- 
> 2.20.1
> 
Reviewed-by: Mukesh Kumar Chaurasiya (IBM) <mkchauras@xxxxxxxxx>