Re: [PATCH v6 3/6] media: dt-bindings: Add Amlogic V4L2 video decoder
From: Krzysztof Kozlowski
Date: Mon Jul 27 2026 - 02:24:18 EST
On Fri, Jul 24, 2026 at 03:04:53PM +0800, Zhentao Guo wrote:
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/amlogic,s4-pll-clkc.h>
> + #include <dt-bindings/clock/amlogic,s4-peripherals-clkc.h>
> + #include <dt-bindings/power/meson-s4-power.h>
> + #include <dt-bindings/reset/amlogic,meson-s4-reset.h>
> + video-codec@fe320000 {
> + compatible = "amlogic,s4-vdec";
> + reg = <0xfe320000 0x10000>,
> + <0xfe036000 0x20>;
> + amlogic,canvas = <&canvas>;
> + reg-names = "dos",
> + "dmc";
Please read carefully DTS coding style.
You also need to address all comments from Sashiko.
Best regards,
Krzysztof