Re: [PATCH] clk: versaclock5: restore cache_only on regcache_sync() failure in resume

[Bui Duc Phuc]

Hi Brian,

Thank you for your feedback.

> I don't see precedent for this pattern anywhere else in the tree. Is
> this an observed problem or something that could theoretically happen?
>
> If this fails in the code today, the pm core will propagate the error,
> and the device won't be marked as resumed.
>

Fair point, there's no precedent in system sleep PM,
though runtime PM has a few cases doing the same thing, so it's not an
entirely new pattern.
This is a defensive fix for a theoretical case; I don't have an actual
bug report for it.

But after a failed resume, what guarantees that no further regmap
accesses can occur
before the next successful resume? If there is such a guarantee, I'm
happy to drop the patch ,
otherwise I'd lean towards keeping it.

Best regards,
Phuc