Re: [PATCH v7 2/4] dt-bindings: leds: nxp,pca963x: add multicolor LED support

From: Krzysztof Kozlowski

Date: Mon Jul 27 2026 - 04:41:35 EST


On 27/07/2026 10:24, Loic Poulain wrote:
>>> compatible:
>>> @@ -96,10 +136,16 @@ allOf:
>>> - nxp,pca9634
>>> then:
>>> patternProperties:
>>> - "^led@[0-9a-f]+$":
>>> + "^.*led@[0-9a-f]$":
>>
>> Why changing this? multi-led is below, so maybe you wanted to combine
>> both?
>
> Yes, I wanted to combine them so that both multi-led@ and led@ nodes
> have their reg property checked by this filter, while the multi-led@
> filter below only checks the reg property of its led@ subnodes, though
> it may not very clear and also too permissive?


Ah, I see now, damn YAML indentation. Code is not that readable, but
looks fine.

Best regards,
Krzysztof