Re: [PATCH v4 02/17] media: ti: vpe: #include <linux/platform_device.h> explicitly

[Hans Verkuil]

On 30/06/2026 11:24, Uwe Kleine-König (The Capable Hub) wrote:
> The driver uses several symbols and structs defined in that header. The
> header is currently included transitively via
> 
> 	"vip.h" ->
> 	<media/v4l2-ctrls.h> ->
> 	<media/media-request.h> ->
> 	<media/media-device.h> ->
> 	<linux/platform_device.h>
> 
> which seems to be on the lower end of the scale between random and
> reliable.
> 
> Acked-by: Danilo Krummrich <dakr@xxxxxxxxxx>
> Reviewed-by: Yemike Abhilash Chandra <y-abhilashchandra@xxxxxx>
> Acked-by: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>
> Link: https://patch.msgid.link/453257c9fa32acc4ab5b3e4c3b010244966a7b9d.1782682124.git.ukleinek@xxxxxxxxxx
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>

Acked-by: Hans Verkuil <hverkuil+cisco@xxxxxxxxxx>

Regards,

	Hans

> ---
>  drivers/media/platform/ti/vpe/vip.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/ti/vpe/vip.c b/drivers/media/platform/ti/vpe/vip.c
> index cb0a5a07a3d4..e56a95f53ea9 100644
> --- a/drivers/media/platform/ti/vpe/vip.c
> +++ b/drivers/media/platform/ti/vpe/vip.c
> @@ -16,6 +16,7 @@
>  #include <linux/interrupt.h>
>  #include <linux/module.h>
>  #include <linux/workqueue.h>
> +#include <linux/platform_device.h>
>  #include <linux/pm_runtime.h>
>  #include <linux/sched.h>
>  #include <linux/mfd/syscon.h>