Re: [PATCH v4 14/17] media: em28xx: Add include for struct usb_device_id

[Hans Verkuil]

On 30/06/2026 11:24, Uwe Kleine-König (The Capable Hub) wrote:
> Traditionally <linux/mod_devicetable.h> was a header defining a plethora
> of structs, among them struct usb_device_id. This was split now with the
> objective that only the relevant bits are included.
> 
> Currently <linux/mod_devicetable.h> is transitively included in
> drivers/media/usb/em28xx/em28xx.h via:
> 
> 	drivers/media/usb/em28xx/em28xx.h ->
> 	<linux/i2c.h> ->
> 	<linux/acpi.h> ->
> 	<linux/device.h> ->
> 	<linux/device/driver.h> ->
> 	<linux/mod_devicetable.h
> 
> To keep struct usb_device_id available once <linux/device/driver.h>
> stops including <linux/mod_devicetable.h>, include it the header
> providing that struct explictly.
> 
> Acked-by: Danilo Krummrich <dakr@xxxxxxxxxx>
> Acked-by: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>
> Link: https://patch.msgid.link/b859817d9f6ec7450302a231e093a5ad5852cb91.1782682124.git.ukleinek@xxxxxxxxxx
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>

Acked-by: Hans Verkuil <hverkuil+cisco@xxxxxxxxxx>

Regards,

	Hans

> ---
>  drivers/media/usb/em28xx/em28xx.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/usb/em28xx/em28xx.h b/drivers/media/usb/em28xx/em28xx.h
> index 21c912403efc..711f281613f5 100644
> --- a/drivers/media/usb/em28xx/em28xx.h
> +++ b/drivers/media/usb/em28xx/em28xx.h
> @@ -23,6 +23,7 @@
>  #include <linux/mutex.h>
>  #include <linux/kref.h>
>  #include <linux/videodev2.h>
> +#include <linux/device-id/usb.h>
>  
>  #include <media/videobuf2-v4l2.h>
>  #include <media/videobuf2-vmalloc.h>