Re: [PATCH RESEND] media: imagination: Fix value clamping in calculate_qp_tables()

[Jai Luthra]

Hi Thorsten,

Thank you for the fix.

Quoting Thorsten Blum (2026-07-27 15:17:30)
> The local variable val was never clamped to 1 or 255 because the return
> value of clamp() was not used. Fix this by assigning the clamped value
> back to val.
> 
> Fixes: a1e294045885 ("media: imagination: Add E5010 JPEG Encoder driver")
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>

Reviewed-by: Jai Luthra <jai.luthra@xxxxxxxxxxxxxxxx>

Thanks,
    Jai

> ---
>  drivers/media/platform/imagination/e5010-jpeg-enc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc.c b/drivers/media/platform/imagination/e5010-jpeg-enc.c
> index 42ad9ee3993b..420cb8bfdb12 100644
> --- a/drivers/media/platform/imagination/e5010-jpeg-enc.c
> +++ b/drivers/media/platform/imagination/e5010-jpeg-enc.c
> @@ -175,12 +175,12 @@ static void calculate_qp_tables(struct e5010_context *ctx)
>                 long long delta = v4l2_jpeg_ref_table_chroma_qt[i] * contrast + luminosity;
>                 int val = (int)(v4l2_jpeg_ref_table_chroma_qt[i] + delta);
>  
> -               clamp(val, 1, 255);
> +               val = clamp(val, 1, 255);
>                 ctx->chroma_qp[i] = quality == -50 ? 1 : val;
>  
>                 delta = v4l2_jpeg_ref_table_luma_qt[i] * contrast + luminosity;
>                 val = (int)(v4l2_jpeg_ref_table_luma_qt[i] + delta);
> -               clamp(val, 1, 255);
> +               val = clamp(val, 1, 255);
>                 ctx->luma_qp[i] = quality == -50 ? 1 : val;
>         }
>  
>

Attachment: signature.asc
Description: signature