Re: [PATCH v2 1/2] watchdog: rzv2h: Convert WDTDCR handling to regmap

[Lad, Prabhakar]

Hi Guenter,

Thank you for the review.

On Mon, Jul 20, 2026 at 3:56 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>
> On Wed, Jul 15, 2026 at 02:39:21PM +0100, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Convert the WDTDCR register access from raw readl/writel variants over to
> > the regmap framework using devm_regmap_init_mmio().
> >
> > This conversion serves as a preparatory refactoring step. It allows the
> > driver to subsequently support syscon-based system controllers natively
> > by passing along alternative regmap handles without forcing messy
> > architectural branching at runtime.
> >
>
> This patch does a bit more than just converting the driver to use regmap.
> It also modifies both reset control handling and runtime pm handling in
> the start, stop, and restart function error handlers. Those changes need
> to be implemented in separate patches and explained. When doing that,
Previously the rzt2h_wdt_wdtdcr_count_stop/rzt2h_wdt_wdtdcr_count_start
didnt return value, with regmap support they do return value. So now
we are just reverting things back in error paths by putting the
resets/pm to their original state.  Please let me know if you still
prefer to split it up.

> please address Sashiko's feedback or explain why the issues it reported
> are of no concern.
>
Ok.

Cheers,
Prabhakar