Re: [PATCH v1] misc: fastrpc: Add missing <linux/bitfield.h> include

[Mukesh Ojha]

On Mon, Jul 27, 2026 at 10:32:38AM +0530, Ekansh Gupta wrote:
> Commit 10555ba6126ed ("misc: fastrpc: Replace hardcoded ctxid mask with
> GENMASK") introduced uses of FIELD_GET() and FIELD_PREP() but omitted
> the header that defines them.  This causes build failures on x86_64
> allmodconfig:
> 
>   drivers/misc/fastrpc.c: error: call to undeclared function 'FIELD_GET'
>   drivers/misc/fastrpc.c: error: call to undeclared function 'FIELD_PREP'
> 
> The missing declaration also causes a secondary -Wformat error because
> the compiler treats the implicit FIELD_GET() as returning int, which
> mismatches the %llx format specifier used in the dev_dbg() call.
> 
> Fix by adding #include <linux/bitfield.h>.
> 
> Fixes: 10555ba6126ed ("misc: fastrpc: Replace hardcoded ctxid mask with GENMASK")
> Cc: stable@xxxxxxxxxx
> Signed-off-by: Ekansh Gupta <ekansh.gupta@xxxxxxxxxxxxxxxx>

It should not have stable tag, as it has not made to any stable tree..
May be it can be fixed inline in Srini tree itself.

Anyway,

Reviewed-by: Mukesh Ojha <mukesh.ojha@xxxxxxxxxxxxxxxx>
-- 
-Mukesh Ojha