Re: [PATCH v3 2/2] power: supply: Add driver for TI BQ25630 charger

[Waqar Hameed]

On Sat, Jul 25, 2026 at 02:57 +0200 Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> wrote:

[...]

>> +static const struct power_supply_desc bq25630_charger_psy_desc = {
>> +	.name = BQ25630_DRV_NAME,
>> +	.type = POWER_SUPPLY_TYPE_USB_TYPE_C,
>
> Just POWER_SUPPLY_TYPE_USB, other USB details should be done via
> USB_TYPES (as you do already). I just cannot remove those types
> because they are used by some old drivers and exposed to userspace
> and thus ABI. I guesss I should add a _DEPRECATED to the in-kernel
> name.

Yeah, maybe we should do that. It would surely help the next person :)

>
> I will fix that up while applying.

Thanks!