Re: [PATCH v30 6/7] arm64: dts: imx8ulp: add secure enclave node

[Frieder Schrempf]

On 24.07.26 11:05, pankaj.gupta@xxxxxxxxxxx wrote:
> From: Pankaj Gupta <pankaj.gupta@xxxxxxx>
> 
> Add support for NXP secure enclave called EdgeLock Enclave firmware (se-fw)
> for imx8ulp-evk.

You only touch the SoC dtsi here, so this description seems inaccurate.

> 
> Add label sram0 for sram@2201f000 and add secure-enclave node
> 
> Signed-off-by: Pankaj Gupta <pankaj.gupta@xxxxxxx>
> Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
> ---
>  arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> index c6d1bb9edf38..182f1444b643 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>  /*
> - * Copyright 2021 NXP
> + * Copyright 2021, 2025 NXP
>   */
>  
>  #include <dt-bindings/clock/imx8ulp-clock.h>
> @@ -153,7 +153,7 @@ sosc: clock-sosc {
>  		#clock-cells = <0>;
>  	};
>  
> -	sram@2201f000 {
> +	sram0: sram@2201f000 {
>  		compatible = "mmio-sram";
>  		reg = <0x0 0x2201f000 0x0 0x1000>;
>  
> @@ -185,6 +185,13 @@ scmi_sensor: protocol@15 {
>  				#thermal-sensor-cells = <1>;
>  			};
>  		};
> +
> +		hsm0: secure-enclave {
> +			compatible = "fsl,imx8ulp-se-ele-hsm";
> +			mbox-names = "tx", "rx";
> +			mboxes = <&s4muap 0 0>, <&s4muap 1 0>;
> +			sram = <&sram0>;
> +		};

Adding this node in imx8ulp.dtsi creates a hard requirement for board
dts to add and reference a memory node. To make this easier for board
maintainers and remove duplication, we might want to provide a default
include file as I did for i.MX93 here: [1]

[1]
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20260727-upstreaming-next-20260609-imx-ocotp-ele-v4-10-1a515de33093@xxxxxxxxxx/

>  	};
>  
>  	cm33: remoteproc-cm33 {
>