Re: ASoC: tas2783-sdw: calibration firmware not re-downloaded after s2idle resume (AMD ACP SoundWire, ASUS ProArt PX13)

From: Mark Brown

Date: Mon Jul 27 2026 - 10:03:33 EST


On Mon, Jul 27, 2026 at 11:13:29AM +0300, Andrey Golovko wrote:

> What does work here: drop the stale cache instead of syncing it, i.e.
> regcache_drop_region(0, UINT_MAX) before tas_io_init() when the device
> re-attaches uninitialized, so the following update_bits() calls read real
> hardware. Side effect: user-set controls fall back to hardware defaults
> after a resume, which seems the lesser evil versus a silent amp.

That's buggy since it will throw away all the userspace configuration
done through controls that map directly onto registers, without
notifications too. The suspend path should be bringing the driver down
to idle and then that should be undone on resume.

Attachment: signature.asc
Description: PGP signature