Re: [PATCH v2] mm/page_reporting: Add page_reporting_delay_ms sysctl

[David Hildenbrand (Arm)]

On 7/25/26 20:17, Pratyush Mallick wrote:
>> Why don't you make the lengths of the line and the section title same?
> Will fix the RST underline length.
> 
>> So it is milliseconds. Why don't you add the unit to the name, like
>> page_reporting_delay_ms?
> Agreed, I'll rename the sysctl to page_reporting_delay_ms.
> Also I think it would better to make this a module param to be consistent
> with page_reporting_order.
> 
>> Also, coule you elaborate why there is 10 seconds maximum limit? What's the
>> problem of having no limit, and why 10 seconds is the reasonable one?
> I don't have a strong justification for where the maximum limit should be set.
> The value is unsigned int, so it's bounded at UINT_MAX ms (~49.7 days)
> So at worst the worker just schedules that far out and reporting
> is effectively paused for that window.
> I'll drop this in V3.

As long as we don't trigger a report as part of the delay change in this patch
set, I'm fine without a MAX.

-- 
Cheers,

David