Re: [PATCH v6 00/22] Introduce SCMI Telemetry support
From: Sudeep Holla
Date: Mon Jul 27 2026 - 10:43:05 EST
Hi Fayssal,
On Mon, Jul 27, 2026 at 01:53:45PM +0000, Fayssal Benmlih wrote:
> Hi Cristian,
>
> Thanks for V6. It addresses a useful subset of the V5 feedback: the
> uninitialized feature flags, signed exponent, group bounds, bool casts,
> SHMTI enumeration loop, scoped ioctl magic, compat support, binary-only
> interface, ABI information, reset, and oversized mmap requests are fixed.
>
Appreciate your efforts in reviewing this series. But the below format
of dumping all the review comments in one place is neither the normal
mailing list practice nor much useful for other reviewer to follow as
one need to map/follow these when reading corresponding code which is
painful IMO.
You can look at other threads on the list for reference or we even have
an AI(sashiko) which does inline reviewing[1].
It will be really helpful if you can switch to that mode for future versions
or comments.
--
Regards,
Sudeep
[1] https://sashiko.dev/#/patchset/20260724144430.1440170-1-cristian.marussi@xxxxxxx